Skip to content

Commit c97ebcc

Browse files
danieljbrucedanieljbruce
authored
feat: Move the metrics handler fixture (#1570)
Summary: This PR simply moves the metrics handler fixture used for tests from the `test` folder to the `test-common` folder. In the next PR the metrics handler fixture will be used for both tests and system tests and when system tests import a file from the test folder and we run `npm run system-test` it runs both the test and the system test suite and we don't want that so right now we are moving the fixture to the `test-common` folder. Next steps: The diagram below shows how the fixture is going to be used in the next PR in system tests. ![With fixture - 2nd plumbing](https://togithub.com/user-attachments/assets/7eedf01b-8a30-4fbc-af6e-f1e17eb4c4f3)
1 parent d475ef2 commit c97ebcc

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

‎test/metrics-collector/metrics-handler-fixture.ts renamed to ‎test-common/metrics-handler-fixture.ts

File renamed without changes.

‎test/metrics-collector/metrics-collector.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import {
2222
StreamingState,
2323
} from '../../src/client-side-metrics/client-side-metrics-attributes';
2424
import {grpc} from 'google-gax';
25-
import {expectedRequestsHandled} from './metrics-handler-fixture';
25+
import {expectedRequestsHandled} from '../../test-common/metrics-handler-fixture';
2626
import * as gax from 'google-gax';
2727
const root = gax.protobuf.loadSync(
2828
'./protos/google/bigtable/v2/response_params.proto'

0 commit comments

Comments
 (0)