Revert "fix: table iterator should not use bqstorage when page_size is not None (#2154)" #2191
+2
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
approved these changes
May 19, 2025
shollyman
approved these changes
May 19, 2025
|
Will merge after we confirm the action plan |
tswast
reviewed
May 21, 2025
Comment on lines
-1900
to
-1904
| @property | ||
| def page_size(self) -> Optional[int]: | ||
| """The maximum number of rows in each page of results from this request, if present.""" | ||
| return self._page_size | ||
|
|
There was a problem hiding this comment.
This would technically be a breaking change, but maybe it's OK since this property was only present in one version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 418814848🦕
reverts changes introduced by #2154